Skip to content

Code Quality: Replaced private const & struct with CsWin32 & Improve comments #16556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2024
Merged

Code Quality: Replaced private const & struct with CsWin32 & Improve comments #16556

merged 2 commits into from
Dec 4, 2024

Conversation

Jack251970
Copy link
Contributor

Replaced private const & struct with CsWin32 & Improve comments following @0x5bfa 's comments for #16508.

@Jack251970
Copy link
Contributor Author

@0x5bfa PTAL.

@yaira2 yaira2 requested a review from 0x5bfa December 4, 2024 02:08
@yaira2
Copy link
Member

yaira2 commented Dec 4, 2024

@Jack251970 thank you for following up on those.

@0x5bfa
Copy link
Member

0x5bfa commented Dec 4, 2024

Thanks, lgtm.

@yaira2 yaira2 merged commit 2a343ee into files-community:main Dec 4, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 4, 2024
@Jack251970 Jack251970 deleted the dev2 branch February 6, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@0x5bfa 0x5bfa Awaiting requested review from 0x5bfa

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jack251970 @yaira2 @0x5bfa